Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another fix due to suddenly deleted public API #808

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Another fix due to suddenly deleted public API #808

merged 1 commit into from
Jun 15, 2023

Conversation

fedinskiy
Copy link
Contributor

@fedinskiy fedinskiy commented Jun 15, 2023 •
edited by michalvavrik
Loading

Summary

Follow up to [1] caused by the same breaking changes[2].
Added some tests to cover affected scenarios from the TS.

[1] #803
[2] fabric8io/kubernetes-client#4662

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy
Another fix due to suddenly deleted public API
e4fa3e0 
Follow up to [1] caused by the same breaking changes[2].
Added some tests to cover affected scenarios from the TS.

[1] quarkus-qe#803
[2] fabric8io/kubernetes-client#4662
@fedinskiy fedinskiy requested a review from michalvavrik June 15, 2023 11:14
@michalvavrik
Copy link
Member

run tests

@fedinskiy
Copy link
Contributor Author

CLi failure in JVM is unrelated, happened today in daily build

michalvavrik
michalvavrik approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedinskiy all that stopped me from approving was 2 adapts, but it has to be done this way, correct? please feel free to merge this when you provide little info, thanks

@michalvavrik
Copy link
Member

an OC CI finishes, bit busy, sorry

@fedinskiy
Copy link
Contributor Author

@michalvavrik regarding two adapt calls:
NamespacedOpenShiftClient does not have load method, which we require, and KubernetesClient can not be adapted into OpenShiftClientImpl("No such adapter" exception); as far as I understand, new instances OpenShiftClientImpl can only be produced by NamespacedOpenShiftClient's adapt method.
This is not an example of good API, but that is already in the title of the PR :)

@michalvavrik
Copy link
Member

Alright, thanks for context :-)

@michalvavrik michalvavrik merged commit beecb72 into quarkus-qe:main Jun 15, 2023
@fedinskiy fedinskiy mentioned this pull request Jun 21, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @michalvavrik